-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split public and private i18n APIs #6022
Split public and private i18n APIs #6022
Conversation
a532707
to
97cb7bc
Compare
97cb7bc
to
0d2e131
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any specific reason why this breaks the entire bot running inside an incus container? Even if local is set to en_US (was C previously), the bot won't start up.
|
See #6517. Our guess is that invalid configuration (which this is caused by) could have been introduced by some version of 3rd-party dashboard cog. We've only seen a single report of this other than yours so we haven't rushed a hot fix release. |
Ty, that fixed it! :) |
Description of the changes
redbot.core._i18n
and name them more sensibly (set_locale
,set_regional_format
, andreload_locales
which I've moved toredbot.core._i18n
and renamed toset_global_locale
,set_global_regional_format
, and_reload_locales
)get_locale_path()
with_
set_contextual_locale()
andset_contextual_regional_format()
set_contextual_locale()
andset_contextual_regional_format()
to verify inputcontext_var.get()
callHave the changes in this PR been tested?
Yes